1. Forum
  2. Fidonet
  3. SYNC PROGRAMMING

  • src/sbbs3/main.cpp

    From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Tue Nov 12 20:08:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ccab84c359406ffea9695db3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()
    --- SBBSecho 3.21-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Nov 14 20:07:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/27e30f1277531509630d3ca8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Better support for multiple hosts handling QWK events

    First, fix the logged username bug in the "Lock exists" log message.
    Next, double check that the trigger file (sem file or REP file) still exists after acquiring the file mutex.

    Use a temp varible (fname) to make the code easier to read.
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Nov 14 20:55:21 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5956805f6e2e985824a86d52
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log event command-lines (repeating event code was redundant)

    Only log messages about QWK mutex files existing when > 60 seconds old
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thu Nov 14 21:09:21 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/3127e4f4b89c73263cadd901
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Detect hung event_thread and log details

    Add log message when spawning background timed event
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Fri Nov 15 12:20:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6df88451e8d9ce67c27bd4d0
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use timestr() instead of ctime_r() for logging full date/times

    Also when detecting a blocked event_thread, log the event_code that is/was running last.
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Nov 15 12:26:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/87b22bda88174a8e03e25558
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

    glob() results might be out of date by the time we look at each file, just
    skip missing QWK pack semaphore files silently. This should resolve the
    ".now already gone" messages too. Hopefully.

    Removed some extraneous quotes around logged event command-lines.
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Nov 15 18:29:09 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f37e9789f42d73d4991d2ff3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use fmutex_open() instead of fmutex() to better protect the pack*.lock files --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Nov 15 22:17:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6dda18740c154c5f099070d1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use fmutex_close() and don't log ENOENT errors when removing pack*.now files --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Nov 15 22:37:59 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/208f263b94e85ef91dc62cc3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Just a little wording update on the fmutex file open log message
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Nov 17 03:02:57 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2fa8db2b6a1a5da43db71887
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

    This condition caused aborting BBS operations via Ctrl-C to fail when connecting from a traditional Telnet client using binary transmission
    mode (e.g. telnet -8) or SyncTERM v1.2rc6.

    The check of rio_abortable was probably enough to disable this function
    during file transfers (e.g. we've had no issues with SSH file transfers
    that might include byte 0x03 received from the client), but I added the
    check for SS_FILEXFER system status check too, perhaps unnecessary.
    --- SBBSecho 3.22-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Nov 18 22:11:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't use uninitialized variable: lockfname

    Where's the compiler warnings guys?
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Tue Nov 19 22:55:43 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

    This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Nov 23 01:24:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/277855436d2143b88bd9a501
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix crash when NO_EVENTS option is set for terminal server

    Don't deref that null pointer
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sun Nov 24 09:34:14 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/26886a8c7ba879f2e84d2650
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Remove ssh_errors variable.

    We're carefully counting the errors, but never looking at the count.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on macOS)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 1 19:57:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/89a884e9dca8116090df2d87
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log the error description upon failure to send on socket
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f83b805f2ebdc68d7612ab6d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

    There still appears to be some race condition with network (Samba) FS
    directory caching and opening/locking of files, so it does seem illogical that the packet file wouldn't exist at this point (since we have the lock file opened) but this does still happen on occasion on Vertrauen.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Dec 14 13:08:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/65ff68a0bb3386cd6d4c3fab
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Always unlock nodefile_mutex before calling errormsg()
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 22 14:37:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/74724d0b83150c1da1a88d74
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    When searching for unused nodes, skip nodes that have sockets in-use

    We already know such nodes are in-use, so no need to read their node.dab
    record and put extra contention on the node.dab file. Hoepfully this
    reduces or eliminates occurrences of the error:
    Node n status is WFC, but the node socket (s) and thread are still in use! Though I kind of expect occurrences of "NODE STATUS FIXUP" errors to likely return.

    We could in theory just track status of nodes in memory (for those
    nodes that this instance of sbbs controls), and not read the node.dab file at all when checking those nodes' status, but:
    - that would prevent out of process control of node status
    e.g. using the node utility to mark a node as offline
    - we'd have to protect instance of in-memory node status checking/changing
    with a mutex
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 22 21:32:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a4f032b82ed2ddfbd23e963d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix-up node status when node status is in-use, but no socket active

    This is a situation we can auto-correct and log a message when we do.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)