1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/nopen.c

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Nov 15 16:45:25 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b9fe6679b94e1bc4dafa6bc3
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    Use sopen(... SH_DENYRW) for fmutex() instead of open()

    O_EXCL doesn't appear to be working very reliably over Samba, so let's add
    file locking to the equation.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Nov 15 22:37:59 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2a4c59134c5de68365babe59
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    Fix for Borland C++ build

    Also, don't get hostname unless we're surely going to write to the file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Nov 18 10:56:33 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/44ce881b07782f3f622d28ea
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    We need to initialize the fd to -1 here (since we zero-it out the fmutex_t)

    and might return before setting it to anything else.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Nov 18 11:16:01 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/dec152b4d4ddb260255be6bf
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    Fix non-Windows build, broken in previous commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 3 09:10:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/11af4bd45489d4a180fb7e6f
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    On Windows, lock the opened mutex file to insure *nix sopen() will fail

    Even though we use O_EXCL, networked file systems still sometimes allow the secondary open() to succeed. We use record locking in xpdev's sopen() implementation for *nix, so this lock will insure such opens (and locks) will now fail.

    This is an attempt to address occassional error on Vertrauen:
    ERROR 2 (No such file or directory) renaming *.rep to *.bad

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Jan 1 03:43:40 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/bde82d5b43813992d1e2bc70
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    Use FILE_RETRY_DELAY macro for consistent retry behavior

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 29 00:46:49 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/a6dd4c68cdba571f7712e1a1
    Modified Files:
    src/sbbs3/nopen.c
    Log Message:
    A little paranoia around comparing a file date/time against current date/time

    The file could be timestamped in the future (especially on a network FS).
    We could maybe have been considering the lock too old (e.g. for REP packet unpacking) in this case and explain some of the collisions I see between
    even threads on different machines unpacking the same REP Packet (or trying to), leading to errors like this one:
    !ERROR 16 (Device or resource busy) renaming /sbbs/data/file/0290.rep
    (20480 bytes) to /sbbs/data/file/0290.rep.697b1a12.bad

    This shouldn't be possible if the mutex files are working as designed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net